[4.4.2.0-4.4.2.2] Global anims seem to take a frame to appear in editor screen

[TheOnyxGuy]

Some of you may know how I've done quite a few screen locking global anims that prevent you from accessing such screens, especially the experimental levelsets.
Anyways, in the levelset "Level Shuffle", yet again, editor is being protected by a couple of anims, specifically one of them waits for 16 frames and then force exits you. But before that, another anim waits for few frames to appear.
The thing is, the first anim is permanent, it covers the whole screen, using '.class: window' and '.draw_masked: false', it does not 'appear' nor 'disappear' in any way. Yet for some reason on 4.4.2.X versions before immediately showing that large black screen it first darkens everything except the border just for a frame (so the whole screen just becomes RocksScreen.png) before properly cutting to the editor screen global animations.

qwgfqqafqf.png (39.28 KiB) Viewed 78 times

Just for comparison I tried the levelset on 4.4.2.0, 4.4.2.1 and 4.4.2.2, it displays that frame. Trying out on 4.4.1.3 - no such frame appears. Technically that's partly my problem that I didn't set the 'global.border.EDITOR' graphic to NULL, but again, that frame didn't appear in 4.4.1.3, so I'm not sure which change in 4.4.2.0 created it. Plus I'm not sure if it's exclusive to just editor. Of course it's not a big problem, but I'm just a little bit confused.

[Holger]

This is a perfectly vaild bug report. Even if it may not be that big of a problem here, it may be in other, yet unknown circumstances.

So I will check which change between 4.4.1.3 and 4.4.2.0 introduced the different behavior, and check why it has the described side effect.

[Holger]

OK, I have just run 4.4.1.3 and 4.4.2.2 side by side with your level set "Level Shuffle (Update 1)".

Do I understand you correctly that the difference should show up when clicking on the (striked through) "Editor" menu entry?

I did that many times now, and I am unable to see any difference between both versions!

Update: I did it even more times, and I may recognize a single frame where the screen is all black -- but this is with version 4.4.1.3, while 4.4.2.2 does not show this single frame (which occurs before the screen is replaced with the "RocksScreen" graphics).

I have tracked down the change that causes this difference, and it is commit a7e0eab62f2a25789e7573fdf729de05a280a939:

Code: Select all

+    // if graphic was cloned, use cloned graphic
+    if (graphic_info[graphic].clone_from != -1)
+      graphic = graphic_info[graphic].clone_from;

This should fix a bug where global animations do not (or not correctly?) support the ".clone_from" parameter for global animations.

However, I can see that you use "global.anim_1.EDITOR.gfx.clone_from: empty_space" in your "graphicsinfo.conf", which does work correctly in both 4.4.1.3 and 4.4.2.2 (replacing "empty_space" with "yamyam" shows this more obviously). (And if I remember correctly, the fix is for cloning graphics for a global animation from another animation, but I don't know in which case this problem happened to me so that I added the above fix.)

Removing that line ("global.anim_1.EDITOR.gfx.clone_from: empty_space") from your "graphicsinfo.conf" shows a totally black screen instead of the "RocksScreen" screen,which seems to be "as expected" (but that's not what your unmodified level set does here, of course).

Summary: For me, your level set looks practically identical in both 4.4.1.3 and 4.4.2.2, with the strange fact that a single black frame (which adds some sort of very short "flickering") does occur in 4.4.1.3, but not in 4.4.2.2.

Not sure if this helps in any way!